Skip to content

bpo-32216: Update dataclasses documentation#6913

Merged
warsaw merged 2 commits intopython:masterfrom
warsaw:dataclass-docs
May 16, 2018
Merged

bpo-32216: Update dataclasses documentation#6913
warsaw merged 2 commits intopython:masterfrom
warsaw:dataclass-docs

Conversation

@warsaw
Copy link
Copy Markdown
Member

@warsaw warsaw commented May 16, 2018

Copy link
Copy Markdown
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one comment, this looks good. Thanks!

Comment thread Doc/library/dataclasses.rst Outdated
See the Python documentation for more information.
:meth:`__hash__` is used by built-in :meth:`hash()`, and when objects are
added to hashed collections such as dictionaries and sets. Having a
:meth:`__hash__` implies that instances of the class are mutable.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutable -> immutable?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@warsaw warsaw merged commit 713a936 into python:master May 16, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @warsaw for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

@warsaw: Please replace # with GH- in the commit message next time. Thanks!

@warsaw warsaw deleted the dataclass-docs branch May 16, 2018 19:51
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2018
(cherry picked from commit 713a936)

Co-authored-by: Barry Warsaw <barry@python.org>
@bedevere-bot
Copy link
Copy Markdown

GH-6918 is a backport of this pull request to the 3.7 branch.

warsaw added a commit that referenced this pull request May 16, 2018
(cherry picked from commit 713a936)

Co-authored-by: Barry Warsaw <barry@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants